Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Upgrade to clang-format-18 #8

Merged
merged 3 commits into from
May 27, 2024
Merged

[CI] Upgrade to clang-format-18 #8

merged 3 commits into from
May 27, 2024

Conversation

esigo
Copy link
Member

@esigo esigo commented Apr 27, 2024

upgrades to clang-format-18 which is shipped with Ubuntu:24.04
fixes open-telemetry/opentelemetry-cpp#2578

@esigo esigo requested a review from a team as a code owner April 27, 2024 11:57
@esigo esigo requested a review from a team April 27, 2024 11:57
owent
owent approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

marcalff
marcalff approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit c053750 into open-telemetry:main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owent owent owent approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Upgrade to a newer version of clang-format
3 participants
@esigo @owent @marcalff